fix(mcp): memory leak — WebSocket frame payload not freed in handleConnection loop#208
Merged
Conversation
…nnection loop (#205) Added `allocated` flag to Frame struct to track when payload memory was allocated during unmasking. Added defer in handleConnection to free the payload when it was allocated, preventing memory leak on masked frames. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gHashTag
added a commit
that referenced
this pull request
Mar 18, 2026
fix(mcp): memory leak — WebSocket frame payload not freed in handleConnection loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allocated: boolfield toFramestruct to track when payload memory was allocated during unmasking of masked WebSocket framesdeferstatement inhandleConnection()loop to free the payload when it was allocated, preventing memory leakProblem
tools/mcp/trinity_mcp/websocket_transport.zighad a memory leak in thehandleConnection()loop. WhenparseFrame()processed a masked WebSocket frame, it allocated memory for the unmasked payload. But after processing the frame in the switch statement, the payload was never freed.Fix
The fix adds an
allocatedboolean to theFramestruct that is set totruewhen memory is allocated for unmasking, and then adeferstatement inhandleConnection()frees the payload when needed:Test Plan
zig buildcompiles successfullyzig ast-checkpassesCloses #205
🤖 Generated with Claude Code