Skip to content

fix(ext): remove inline script (CSP violation) + CI enforcement (Closes #189) #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gHashTag wants to merge 1 commit into from
Closed

fix(ext): remove inline script (CSP violation) + CI enforcement (Closes #189) #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@ jobs:
test -f extension/sidepanel.html || (echo "extension/sidepanel.html missing!" && exit 1)
echo "L8 OK: extension artifacts present"

- name: Check no inline scripts in HTML (CSP compliance)
run: |
if grep -rn '<script[^>]*>[^<]' extension/*.html 2>/dev/null | grep -v 'src='; then
echo "CSP VIOLATION: inline <script> found in HTML"
exit 1
fi
echo "CSP OK: no inline scripts"

- name: cargo clippy (L3 law — zero warnings)
run: cargo clippy --all-targets --all-features -- -D warnings

Expand Down
58 changes: 57 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 5 additions & 11 deletions extension/sidepanel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Trios — Queen Trinity Sidebar</title>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Trios</title>
</head>
<body>
<script type="module">
import init, { run } from './dist/wasm/trios_ext.js';
async function main() {
await init('./dist/wasm/trios_ext_bg.wasm');
run();
}
main();
</script>
<div id="root"></div>
<script src="dist/bootstrap.js" type="module"></script>
</body>
</html>
Loading