Fix zformatter on Apple and POSIX.1-2024 conforming platforms #3353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workaround) Apple platforms have had the tm_gmtoff-field at least since Mac OS X 10.0, as are POSIX.1-2024 conforming systems, which are also required to support it. This has the unfortunate effect to use the SunOS/Solaris fallback, which doesn't compute the correct value if the passed value of tm isn't the current system time, i.e. localtime(::time()) (gabime#3351).
Owner
|
Thanks @toh-ableton . Please fix the windows tests (\r\n vs. \n) |
Contributor
Author
|
@gabime I'm not sure how to best do this. The other tests don't seem to have this issue. Feel free to push a fixup; I will be out of office for a few days. |
Owner
|
Fixed and merged in PR #3366 Thanks @toh-ableton |
Contributor
Author
|
Thank you @gabime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a missing test (#3352), Apple and POSIX.1-2024 conforming platforms choose a buggy workaround in
utc_minutes_offset()(#3351).This PR adds a test that demonstrate the bug and fixes it for Apple and POSIX.1-2024 by adapting the feature test.