To catch a remount: Add debug information#608
Merged
Conversation
Collaborator
Author
|
Just improve a bit debug information. Now one can just click on function signature to found the |
Collaborator
|
@theKashey very interesting, I like the idea. I keep it opened, I have to take a deeper look before merging it. |
Collaborator
Author
|
Hooray! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of Hot Reloading - is to apply code changes on a live application.
But, If you can NOT preserve application state, including internal component state and component life cycle - it is better NOT to use Hot Loading features at all.
Unfortunately, It is not easy to make this feature work for any complex application - any @decorator, functional composition chain or too complex HoC - and everything will break.
This PR will solve this issue. It will add debug information, so a developer will understand which component is not patched and is causing local remount.
There are 3 types of components:
idsByType.hasCreatedElementsByTypesignaturetoknownSignaturesfor the first time, and reported as an issue for the second. But only after HMR event.HRM event will be caught by re-registration of any normal component. In this case some
differentcomponents with the same signature (styled-components for example) will not soil console during startup.