release: prepare v0.1.6#20
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 038b00c878
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tag_sha="$(git -C "$REPO_ROOT" rev-parse "$RELEASE_TAG")" | ||
| [ "$head_sha" = "$tag_sha" ] || die "Refusing to package the notarized DMG because HEAD does not match $RELEASE_TAG. HEAD: $head_sha. Tag: $tag_sha." |
There was a problem hiding this comment.
create_release_tag() creates an annotated tag (git tag -a), but this check uses git rev-parse "$RELEASE_TAG", which resolves to the tag object SHA rather than the underlying commit SHA. That makes head_sha and tag_sha differ even when HEAD is exactly what the tag points to, so the new default DMG packaging path aborts every standard release before merge. Peel the tag to a commit (for example with ^{} / ^{commit}) before comparing.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31505f5fc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dmg_path="$REPO_ROOT/build/distribution/Gmax-$RELEASE_TAG.dmg" | ||
| sha_path="$dmg_path.sha256" |
There was a problem hiding this comment.
package_local_release_dmg() invokes package-notarized-dmg.sh, which writes artifacts to GMAX_DMG_OUTPUT_DIR when that environment variable is set, but upload_local_release_dmg() always looks in build/distribution. In runs that use a non-default output directory, packaging succeeds but the later upload step fails with “Expected notarized DMG…” after the PR has already been merged and the GitHub release object created, leaving the release without assets.
Useful? React with 👍 / 👎.
1 participant
Release
release/dmg-distributionmainupdates behind pull request review and CIv0.1.6was created locally before this PR so the reviewed release candidate is preserved exactlyReview Loop
Before merge,
scripts/repo-maintenance/release.shwatches CI and stops on review comments unless the maintainer has already addressed or resolved them and reruns with--review-comments-addressed.