Skip to content

Fix DIII-D mapping for ec_launchers with the top system#405

Merged
torrinba merged 2 commits into
masterfrom
fix_d3d_ec_launchers
May 21, 2026
Merged

Fix DIII-D mapping for ec_launchers with the top system#405
torrinba merged 2 commits into
masterfrom
fix_d3d_ec_launchers

Conversation

@torrinba
Copy link
Copy Markdown
Collaborator

@torrinba torrinba commented Apr 28, 2026

Description

There was a change in the data format uploaded to MDSplus for this system that the mapping wasn't robust enough to handle.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

import omas
from omas.machine_mappings import d3d

ods = omas.ODS()
d3d.ec_launcher_active_hardware(ods, 204312)

Pre-Merge Checklist

  • OMFIT has been tested with this OMAS version and you will create a PR on OMFIT that updates the OMAS submodule once this has been merged.
  • Version number has been incremented if this is a major modification or important bug fix
    • To increment the version: Edit the version number in omas/version file
    • Follow semantic versioning: MAJOR.MINOR.PATCH (e.g., 0.94.20.94.3 for bug fixes, 0.94.20.95.0 for new features)
    • A GitHub release will be automatically created when this PR is merged if the version number has changed

There was a change in the data format uploaded to MDSplus for this system that the mapping wasn't robust enough to handle.
Copy link
Copy Markdown
Collaborator

@AreWeDreaming AreWeDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minimally invasive and successful bug fix.

@AreWeDreaming
Copy link
Copy Markdown
Collaborator

Ready to merge once regression passes.

@torrinba torrinba merged commit f322815 into master May 21, 2026
8 checks passed
@torrinba torrinba deleted the fix_d3d_ec_launchers branch May 21, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants