fix: Compose UI 품질 개선 — contentType, derivedStateOf, 색상 토큰, 접근성#78
Merged
fix: Compose UI 품질 개선 — contentType, derivedStateOf, 색상 토큰, 접근성#78
Conversation
- ZenAllTracksTabContent: isSelectionMode에 derivedStateOf 적용, itemsIndexed에 contentType 추가 - ZenPlayerBar: playbackProgress에 derivedStateOf 적용, Color.White → MaterialTheme 토큰으로 교체 - PlaylistDetailScreen: itemsIndexed contentType 추가, TealThemeColor 하드코딩 → MaterialTheme 토큰으로 교체 - AlbumArtThumbnail: contentDescription null → '앨범 아트'로 접근성 보완 - ZenPomodoroTimer: 타이머 Text에 semantics contentDescription 추가
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isSelectionMode(ZenAllTracksTabContent),playbackProgress(ZenPlayerBar)에derivedStateOf적용으로 불필요한 리컴포지션 감소itemsIndexed에contentType추가(ZenAllTracksTabContent, PlaylistDetailScreen)로 LazyColumn 재사용 최적화Color.White→MaterialTheme.colorScheme.surface/onPrimary,TealThemeColor하드코딩 →MaterialTheme.colorScheme.primary/onPrimary로 교체AlbumArtThumbnailcontentDescription 보완,ZenPomodoroTimer타이머 숫자에 semantics 추가변경 파일
zen/musicselect/ZenAllTracksTabContent.ktzen/miniplayer/ZenPlayerBar.ktfeatures/playlist/ui/PlaylistDetailScreen.ktcore/ui/component/AlbumArtThumbnail.ktfeatures/timer/ui/components/ZenPomodoroTimer.kt