Conversation
Owner
gagip
commented
Nov 1, 2025
- 3개 서브커맨드 (parse/search/projects) 추가
- 다중 포맷 출력 지원 (text/json/csv)
- 3개 서브커맨드 (parse/search/projects) 추가 - 다중 포맷 출력 지원 (text/json/csv)
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CLI from a single-command interface to a subcommand-based architecture with three commands: parse, search, and projects. It also adds comprehensive test coverage for formatters and CLI commands.
- Refactored CLI to use subcommands (parse, search, projects) instead of positional arguments
- Added output formatters (text, json, csv) for search results with corresponding tests
- Enhanced UTF-8 encoding support for stdout/stderr streams
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cli.py | Refactored from single-command to subcommand architecture with proper encoding setup |
| git_log_analysis/cli/init.py | New module exporting command setup functions |
| git_log_analysis/cli/types.py | Type definitions for CLI argument parsers |
| git_log_analysis/cli/parse_command.py | Parse subcommand implementation |
| git_log_analysis/cli/search_command.py | Search subcommand with filtering and output format options |
| git_log_analysis/cli/projects_command.py | Projects subcommand showing available projects and statistics |
| git_log_analysis/cli/formatters.py | Output formatters for text, JSON, and CSV formats |
| git_log_analysis/mcp/data_loader.py | Added UTF-8 encoding configuration for logging |
| tests/test_formatter.py | Comprehensive tests for all formatters |
| tests/test_cli_commands.py | Integration tests for CLI commands via subprocess |
| CLAUDE.md | Updated documentation with new CLI usage examples |
| .gitignore | Added settings.local.json to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
git_log_analysis/cli/types.py
Outdated
Comment on lines
+4
to
+5
|
|
||
| SubParser = argparse._SubParsersAction |
There was a problem hiding this comment.
Accessing private API argparse._SubParsersAction is not recommended. Use the public type annotation argparse._SubParsersAction[argparse.ArgumentParser] or consider using typing.Any if type hints are needed.
Suggested change
| SubParser = argparse._SubParsersAction | |
| from typing import Any | |
| SubParser = Any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.