Skip to content

Fail action when Lambda function invocation fails#6

Merged
gagoar merged 23 commits intomasterfrom
siliu/proper-error-throwing
Jul 5, 2020
Merged

Fail action when Lambda function invocation fails#6
gagoar merged 23 commits intomasterfrom
siliu/proper-error-throwing

Conversation

@cyamonide
Copy link
Copy Markdown
Collaborator

@cyamonide cyamonide commented Jul 3, 2020

Previously, failed Lambda invocations would be reported as successful.

This PR adds the input parameter SUCCEED_ON_FUNCTION_FAILURE, giving users the option to succeed this action on function failure, while changing the default action behavior to fail the action when the function fails.

@cyamonide cyamonide requested a review from gagoar July 3, 2020 19:56
@cyamonide cyamonide self-assigned this Jul 3, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 3, 2020

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           40        44    +4     
  Branches         3         4    +1     
=========================================
+ Hits            40        44    +4     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf31aa9...1a7b13c. Read the comment docs.

Copy link
Copy Markdown
Owner

@gagoar gagoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to publish this.so it will take a minute.

@gagoar gagoar merged commit d3a63cc into master Jul 5, 2020
@gagoar gagoar deleted the siliu/proper-error-throwing branch July 5, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants