fix: debug assertions that failed by withdraw-limit OnTransferHook#1400
Merged
enthusiastmartin merged 1 commit intomasterfrom Mar 25, 2026
Merged
fix: debug assertions that failed by withdraw-limit OnTransferHook#1400enthusiastmartin merged 1 commit intomasterfrom
enthusiastmartin merged 1 commit intomasterfrom
Conversation
|
Crate versions that have not been updated:
Runtime version has not been increased. |
cl0w5
approved these changes
Mar 25, 2026
|
Quick benchmark at commit 7c60c03 has been executed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OnTransferHook eagerly called
convert_to_hdxon every transfer, before checking whether the result is actually needed, which caused some debug assertions to fail.How Has This Been Tested?
make test