Conversation
Rolling DCA schedules (total_amount = 0) were being prematurely terminated when the price of the bought asset increased after schedule creation. The remaining_amount (set once at creation, never updated for rolling schedules) would become smaller than the recalculated amount_for_next_trade, triggering completion even though the user had plenty of funds. Skip both budget termination checks for rolling schedules since their budget is infinite by definition.
|
Crate versions that have been updated:
Runtime version has been increased. |
enthusiastmartin
approved these changes
Apr 12, 2026
# Conflicts: # Cargo.lock # integration-tests/Cargo.toml
|
Quick benchmark at commit b7fee65 has been executed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an issue,namely a check for buy orders where we check if the remaining amount is smaller than the next trade amount. If so we complete the DCA.
But for rolling DCA, this remaining amount is always constant:
hydration-node/pallets/dca/src/lib.rs
Line 936 in 21a93e4
So when the pair price changes a lot since schedule creation, this can lead to issue
the simplest solution could be to skip this check in case of rolling DCA.