Skip to content

Conversation

@machristie
Copy link
Collaborator

Introduces a new abstraction, AppConfigurer, that configures an
application on a host. Currently this is done by SSHing in and either
running a script or running an Ansible playbook.

The Ansible playbook execution logic was extracted out of the
CloudMan2AppPlugin.

@machristie machristie force-pushed the issue-151-app-configurer-refactor branch from 89a300d to a75e1e4 Compare July 20, 2018 00:37
Introduces a new abstraction, AppConfigurer, that configures an
application on a host. Currently this is done by SSHing in and either
running a script or running an Ansible playbook.

The Ansible playbook execution logic was extracted out of the
CloudMan2AppPlugin.
@machristie machristie force-pushed the issue-151-app-configurer-refactor branch from a75e1e4 to 999b9d1 Compare July 20, 2018 00:40
@coveralls
Copy link

Coverage Status

Coverage decreased (-36.7%) to 19.873% when pulling 999b9d1 on machristie:issue-151-app-configurer-refactor into 06b1564 on galaxyproject:dev.

@coveralls
Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage decreased (-34.8%) to 21.739% when pulling 999b9d1 on machristie:issue-151-app-configurer-refactor into 06b1564 on galaxyproject:dev.

@afgane
Copy link
Contributor

afgane commented Jul 20, 2018

Thanks for following through with this!
Haven't tested it yet but looks good to me.

@machristie
Copy link
Collaborator Author

Thanks. I should mention that during the hackathon I got as far as launching CloudMan 2. CloudMan 2 didn't start up successfully, if I recall correctly, but I think that was because of an issue unrelated to refactor.

@nuwang nuwang merged commit bf902f5 into galaxyproject:dev Sep 5, 2018
@nuwang nuwang removed the in progress label Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants