Update requirements and add container building GHA#154
Merged
nuwang merged 2 commits intogalaxyproject:masterfrom May 10, 2022
Merged
Update requirements and add container building GHA#154nuwang merged 2 commits intogalaxyproject:masterfrom
nuwang merged 2 commits intogalaxyproject:masterfrom
Conversation
nuwang
reviewed
May 10, 2022
Member
nuwang
left a comment
There was a problem hiding this comment.
Thanks for fixing these, and great to see the docker build being fixed. One comment on pyyaml.
| @@ -1,5 +1,6 @@ | |||
| # needed by celery | |||
| sqlalchemy | |||
| pyYAML<6.0 | |||
Member
There was a problem hiding this comment.
I think if we do a search/replace of yaml.load with yaml.safe_load, we can use the latest pyyaml? I believe safe_load is recommended anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeError: load() missing 1 required positional argument: 'Loader'inyaml.load()for 6.0+Existing image with these changes at
almahmoud/cloudman-server:latestif you want to try it out first