Skip to content

Update requirements and add container building GHA#154

Merged
nuwang merged 2 commits intogalaxyproject:masterfrom
almahmoud:update-container
May 10, 2022
Merged

Update requirements and add container building GHA#154
nuwang merged 2 commits intogalaxyproject:masterfrom
almahmoud:update-container

Conversation

@almahmoud
Copy link
Copy Markdown
Member

@almahmoud almahmoud commented May 9, 2022

  • pyYAML<6.0 because of TypeError: load() missing 1 required positional argument: 'Loader' in yaml.load() for 6.0+
  • [full] to cloudbridge to properly include all requirements
  • Adds building and pushing workflow (I don't have permissions to add secrets for this repo, so docker creds will still need to be added)
    Existing image with these changes at almahmoud/cloudman-server:latest if you want to try it out first

@almahmoud almahmoud requested a review from nuwang May 9, 2022 20:29
Copy link
Copy Markdown
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these, and great to see the docker build being fixed. One comment on pyyaml.

Comment thread requirements.txt Outdated
@@ -1,5 +1,6 @@
# needed by celery
sqlalchemy
pyYAML<6.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we do a search/replace of yaml.load with yaml.safe_load, we can use the latest pyyaml? I believe safe_load is recommended anyway.

@nuwang nuwang merged commit e0da023 into galaxyproject:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants