Skip to content

PIck Value Module #136

Merged
mvdbeek merged 2 commits intomainfrom
pick_value
Mar 18, 2026
Merged

PIck Value Module #136
mvdbeek merged 2 commits intomainfrom
pick_value

Conversation

@jmchilton
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.03%. Comparing base (e9d5c7d) to head (76432f5).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   41.03%   41.03%           
=======================================
  Files          51       51           
  Lines        1974     1974           
  Branches      441      441           
=======================================
  Hits          810      810           
  Misses       1047     1047           
  Partials      117      117           
Flag Coverage Δ
unittests 41.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jmchilton and others added 2 commits March 17, 2026 09:45
Support pick_value workflow module in gxformat2 conversion and export.
Adds type to NativeGalaxyStepType/STEP_TYPES, transform function for
import, export handler, and num_inputs computation from connections.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jmchilton jmchilton changed the title [WIP] PIck Value Module PIck Value Module Mar 18, 2026
@jmchilton
Copy link
Member Author

Sorry to nominate you @mvdbeek - but you're the only one who understands the Galaxy code and the only ones who understands the CWL-in-Galaxy code - so I think I need you to review the work. But I want to setup the pair of PRs in a way that makes your review as easy, informative, and productive as possible.

How would you like to review this code - this is green and the Galaxy variant was green before my rebasing (on my playwright fixes which is also green) - https://github.com/galaxyproject/galaxy/compare/dev...jmchilton:galaxy:pick_value_module?expand=1. Would you like me to merge this and open a Galaxy PR with a gxformat2 version update or would you like me to open the Galaxy PR with a dependency on this branch hacked into pyproject/requirements.txt and get your sign off on that before I merge this?

@mvdbeek mvdbeek merged commit 6541586 into main Mar 18, 2026
20 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Mar 18, 2026

Let's merge & release, it looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants