Fix / in step labels breaking source reference parsing#148
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 41.03% 41.03%
=======================================
Files 51 51
Lines 1974 1974
Branches 441 441
=======================================
Hits 810 810
Misses 1047 1047
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add resolve_source_reference() helper that matches known labels (longest first) before falling back to split on `/`. Fixes converter, normalize, and cytoscape call sites. Closes #145 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
038ab6e to
08ae81c
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_source_reference()helper inmodel.pythat matches known labels (longest first) before falling back tosplit("/"), handling labels likeHost/Contaminant Reference Genomeconverter.py(BaseConversionContext.step_output()),normalize.py(_replace_anonymous_output_references,_ensure_implicit_step_outs), andcytoscape.py(to_cytoscape) to use the new helper/in labelsCloses #145
Test plan
resolve_source_referencecover: simple labels, slash-in-label with/without output, multiple slashes, longest-match ordering, fallback behavior/in input labels, step labels, and chained connections🤖 Generated with Claude Code