Skip to content

Conversation

@DAnn2012
Copy link
Contributor

@DAnn2012 DAnn2012 commented Sep 23, 2024

Hello @bfintal

Fix String Translation in index.js

Added the text domain to this string because it is no longer present among the default ones in WordPress 6.6.x.

Fix #3433

@DAnn2012
Copy link
Contributor Author

DAnn2012 commented Oct 1, 2024

Hello @bfintal

Please could you take a look at this PR of mine?

Thanks.

@benniledl
Copy link

The original string is still present, it has just changed from:
Select a variation to start with.
To:
Select a variation to start with:

@DAnn2012
Copy link
Contributor Author

DAnn2012 commented Dec 5, 2024

True. But this plugin is compatible with WP 6.4 or higher and currently displays the translation only with versions 6.4 and 6.5 (and by updating the string the translation would be displayed only with versions 6.6 and 6.7). The proposed change is to display the translation with all currently compatible versions.

@DAnn2012
Copy link
Contributor Author

Hello @bfintal

Please could you take a look at this PR of mine?

Thanks.

@DAnn2012
Copy link
Contributor Author

Hello @mxkae

as soon as you can, could you take a look at this PR?

Thanks.

@DAnn2012
Copy link
Contributor Author

Hello @Arukuen

as soon as you can, could you take a look at this PR?

Thanks.

@DAnn2012
Copy link
Contributor Author

Hello @bfintal

Please could you take a look at this PR of mine?

Thanks.

@DAnn2012
Copy link
Contributor Author

DAnn2012 commented Jun 2, 2025

Hello @malalacharm

Please could you take a look at this PR of mine?

Thanks.

@bfintal bfintal merged commit a3840cd into gambitph:develop Jul 16, 2025
@bfintal
Copy link
Contributor

bfintal commented Jul 16, 2025

Thanks and apologies for the delay!

@DAnn2012
Copy link
Contributor Author

Hello @bfintal

Thank you so much. Could you please take a look at these others too: #3366 and #3414 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A string is not displayed as translated (on WP 6.6 and higher)

3 participants