Fix (WooCommerce): remove css styles displayed on shop page #3381
Conversation
🤖 Pull request artifacts
|
bfintal
left a comment
bfintal
left a comment
There was a problem hiding this comment.
I suggest we create a new file specifically for WC compatibility.
src/kses.php
Outdated
| return $content; | ||
| } | ||
|
|
||
| add_filter('pre_kses', 'stackable_pre_kses_woocomerce_shop', 10, 3); |
There was a problem hiding this comment.
See whether you can check for the existence of the is_shop function prior to doing the add_filter
src/css-optimize.php
Outdated
| if ( is_singular() && ! is_preview() && ! is_attachment() ) { | ||
| $post_id = get_the_ID(); | ||
| // DEV NOTE #2: Check for WooCommerce Shop Page as well | ||
| if ( ( is_singular() && ! is_preview() && ! is_attachment() ) || ( function_exists('is_shop' ) && is_shop() ) ) { |
There was a problem hiding this comment.
This condition is becoming long and hard to read, can we split this to make it more readable? I feel uneasy that we're mingling WooCommerce code inside our normal behavior, let's add a filter so that we can split woocommerce compatibility into it's own file - we can add a src/compatibility/woocommerce.php and place the necessary compatibility code there.
$optimize_css = is_singular() && ! is_preview() && ! is_attachment();
$optimize_css = apply_filters( 'stackable/load_cached_css_for_post', $optimize_css );
if ( $optimize_css ) {
// ...
src/kses.php
Outdated
| * In WooCommerce Shop page, <style> tags are stripped out and the CSS styles are displayed in the frontend. | ||
| * This function removes the <style> tags and CSS styles before they are stripped out. | ||
| */ | ||
| if ( ! function_exists( 'stackable_pre_kses_woocomerce_shop' ) ) { |
There was a problem hiding this comment.
Can we move this code from here to the new src/compatibility/woocommerce.php file suggested above?
No description provided.