Skip to content

Fix (Color Schemes and Spacing): wrap new styles with classnames for color schemes and spacing#3476

Merged
bfintal merged 6 commits intodevelopfrom
fix/color-schemes-and-spacing-separate-styles
Mar 31, 2025
Merged

Fix (Color Schemes and Spacing): wrap new styles with classnames for color schemes and spacing#3476
bfintal merged 6 commits intodevelopfrom
fix/color-schemes-and-spacing-separate-styles

Conversation

@kaeizen
Copy link
Copy Markdown
Contributor

@kaeizen kaeizen commented Mar 31, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2025

🤖 Pull request artifacts

file commit
pr3476-stackable-3476-merge.zip 5d9d2bb

github-actions Bot added a commit that referenced this pull request Mar 31, 2025
github-actions Bot added a commit that referenced this pull request Mar 31, 2025
github-actions Bot added a commit that referenced this pull request Mar 31, 2025
github-actions Bot added a commit that referenced this pull request Mar 31, 2025
github-actions Bot added a commit that referenced this pull request Mar 31, 2025
github-actions Bot added a commit that referenced this pull request Mar 31, 2025
@bfintal bfintal requested a review from Copilot March 31, 2025 13:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR wraps new style changes with appropriate classnames to improve color schemes and spacing behavior throughout the editor. Key changes include:

  • Adding a utility function (onClassChange) to monitor class changes.
  • Updating loader function calls in spacing-and-borders and buttons-and-icons to include an additional parameter.
  • Enhancing the color schemes editor loader to toggle a specific class on the editor element based on style changes.

Reviewed Changes

Copilot reviewed 11 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/plugins/global-settings/utils/block-layout-utils.js Introduces onClassChange to observe class attribute mutations.
src/plugins/global-settings/spacing-and-borders/index.js Updates the call to useBlockLayoutEditorLoader with a second parameter.
src/plugins/global-settings/color-schemes/utils.js Comments out the previous implementation regarding inherited values with added developer notes.
src/plugins/global-settings/color-schemes/editor-loader.js Imports onClassChange and implements logic to add/remove a class on the editor element.
src/plugins/global-settings/buttons-and-icons/index.js Updates the call to useBlockLayoutEditorLoader with a second parameter.
Files not reviewed (15)
  • src/block/columns/editor.scss: Language not supported
  • src/block/columns/style.scss: Language not supported
  • src/block/countdown/style.scss: Language not supported
  • src/block/divider/style.scss: Language not supported
  • src/block/icon-list-item/style.scss: Language not supported
  • src/block/icon-list/editor.scss: Language not supported
  • src/block/icon-list/style.scss: Language not supported
  • src/block/number-box/style.scss: Language not supported
  • src/block/progress-bar/style.scss: Language not supported
  • src/block/progress-circle/style.scss: Language not supported
  • src/block/table-of-contents/style.scss: Language not supported
  • src/block/timeline/style.scss: Language not supported
  • src/plugins/global-settings/buttons-and-icons/index.php: Language not supported
  • src/plugins/global-settings/color-schemes/index.php: Language not supported
  • src/plugins/global-settings/spacing-and-borders/index.php: Language not supported

@bfintal bfintal merged commit 80b4b7d into develop Mar 31, 2025
7 of 8 checks passed
@bfintal bfintal deleted the fix/color-schemes-and-spacing-separate-styles branch March 31, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants