fix: force all the image in the horizontal scroller to load immediate…

[Arukuen]

…ly for height calculation

Summary by CodeRabbit

• Bug Fixes

  • Improved layout stability in horizontal scroller and carousel components by ensuring images load during initial layout, reducing layout shifts and visual jumps.

• Chores

  • Removed legacy lazy-loading workaround and associated editor/admin toggle; the lazy-load option has been removed from settings and the welcome UI.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds eager image loading in carousel and horizontal scroller frontend JS; removes server-side lazy-loading workarounds and related editor setting and admin UI toggle for carousel lazy loading.

Changes

Cohort / File(s)	Summary
Frontend: Horizontal Scroller src/block/horizontal-scroller/frontend-horizontal-scroller.js	Sets loading='eager' on images during initialization and updates comment; retains draggable=false.
Frontend: Carousel src/block/carousel/frontend-carousel.js	Sets loading='eager' on carousel images during initialization (before accessibility tweaks and property setup).
PHP: Carousel lazy-load removal src/block/carousel/index.php	Removes functions and filters that added stk-img-carousel classes and skipped adding loading attributes (entire lazy-loading workaround block deleted).
PHP: Horizontal Scroller lazy-load removal src/block/horizontal-scroller/index.php	Removes functions and filters that added stk-img-horizontal-scroller classes and skipped loading attributes (lazy-loading workaround block deleted).
Editor settings src/editor-settings.php	Removes registration and loading of stackable_enable_carousel_lazy_loading from editor settings payload.
Admin UI src/welcome/admin.js	Removes the "Lazy Load Images within Carousels" toggle from the Optimizations navigation and settings UI.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fix: cimo premium upsell #3653: Modifies the register_settings flow in src/editor-settings.php (adds/removes editor setting registrations), related to editor settings changes.

Poem

🐰 I hopped through code at break of day,
Told sleepy pics, "No more delay."
Now eager eyes peek, heights align,
Scrollers glide smooth — a neat design.
Nibbles of joy, a carrot-sized shine. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title focuses primarily on horizontal scroller image loading but the changeset also makes substantial changes to carousel image loading and removes lazy-loading infrastructure. The title is partially related but incomplete.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aae022f and a59db5e.

📒 Files selected for processing (4)

• src/block/carousel/index.php
• src/block/horizontal-scroller/index.php
• src/editor-settings.php
• src/welcome/admin.js

💤 Files with no reviewable changes (4)

• src/editor-settings.php
• src/welcome/admin.js
• src/block/carousel/index.php
• src/block/horizontal-scroller/index.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: PHP 8.2 and WP 6.5.5
• GitHub Check: build
• GitHub Check: PHP 7.3 and WP latest
• GitHub Check: PHP 8.2 and WP latest
• GitHub Check: PHP 8.2 and WP 6.7.2
• GitHub Check: PHP 8.2 and WP 6.6.2
• GitHub Check: PHP 7.3 and WP 6.5.5

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Pull request artifacts

file	commit
pr3672-stackable-3672-merge.zip	a59db5e

[github-actions]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3672-stackable-3672-merge.zip"}}]}