fix: avoid conflict in the enqueing script with conditional display#3689
fix: avoid conflict in the enqueing script with conditional display#3689
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModified the block script enqueue logic in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Pull request artifacts
|
fixes #3688
Issue: When the first carousel (or any other block with frontend script) in the post is removed using
Conditional Display, its frontend script will not be enqueued.The conditional display feature removes the block content of the blocks to avoid rendering the block. If there's no block content for that block, the
wp_enqueue_scriptdoes not proceed (tested). However, the$scripts_loadedtracker, prior to this PR, attempts to enqueue the script, fails silently, but still records that the script is loaded. This will omit the succeeding attempts to enqueue the script, even though they are valid with proper block content.This PR makes the
Conditional Displayrun first to avoid race condition (in the premium PR), and check for empty block content before enqueueing the script since it might be removed withConditional Display.Summary by CodeRabbit