Skip to content

Small adjustment to default gambit node level spacing logic #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwardchalstrey1 merged 4 commits into from
Dec 4, 2025
Merged

Small adjustment to default gambit node level spacing logic #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f46f3dd
adjust node level logic
edwardchalstrey1 Dec 4, 2025
2729c5b
reduce default level spacing to 4
edwardchalstrey1 Dec 4, 2025
d638e9a
update notebook
edwardchalstrey1 Dec 4, 2025
d8bc571
fix: update Python version matrix to include 3.14
edwardchalstrey1 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.13"]
python-version: ["3.10", "3.14"]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions src/draw_tree/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,7 +1261,7 @@ def generate_tikz(
game: str | "pygambit.gambit.Game",
save_to: Optional[str] = None,
scale_factor: float = 0.8,
level_spacing: int = 6,
level_spacing: int = 4,
sublevel_spacing: int = 2,
width_spacing: int = 2,
show_grid: bool = False,
Expand Down Expand Up @@ -1357,7 +1357,7 @@ def draw_tree(
game: str | "pygambit.gambit.Game",
save_to: Optional[str] = None,
scale_factor: float = 0.8,
level_spacing: int = 6,
level_spacing: int = 4,
sublevel_spacing: int = 2,
width_spacing: int = 2,
show_grid: bool = False,
Expand Down
8 changes: 4 additions & 4 deletions src/draw_tree/gambit_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,20 @@
def determine_node_level(
gbt_level: int,
gbt_sublevel: int,
level_multiplier: int = 6,
level_multiplier: int = 4,
sublevel_multiplier: int = 2,
) -> int:
"""Determine the node level in the .ef format based on Gambit layout levels."""
# If node is in an infoset
if gbt_level > 1 and gbt_sublevel != 0:
if gbt_sublevel != 0:
return (gbt_level * level_multiplier) + ((gbt_sublevel - 1) * sublevel_multiplier) - (level_multiplier / 2)
return gbt_level * level_multiplier
return (gbt_level * level_multiplier) - (level_multiplier / 2)


def gambit_layout_to_ef(
game: pygambit.gambit.Game,
save_to: Optional[str] = None,
level_multiplier: int = 6,
level_multiplier: int = 4,
sublevel_multiplier: int = 2,
xshift_multiplier: int = 2
) -> str:
Expand Down
Loading