New syntax for node children and paths (#587)#588
Merged
Conversation
It is perhaps telling that this was not a very useful way to index children, but this change did not break any tests!
9 tasks
Member
Yes, thanks, I've re-written it and and it's much nicer now. |
…ldren-and-paths' into 587-feat-new-syntax-for-node-children-and-paths
Closes #587.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements idea in #587.
Have added tests, but not yet added examples to user guide pending input on whether we want to do anything slightly different.
There should be some opportunities also to use this in the test suite - e.g. @rahulsavani, not to be re-writing the Kuhn poker example already, but would this syntax make it a bit more clear than what you've done?