Skip to content

Conversation

@StephenPasteris
Copy link
Collaborator

Issues closed by this PR

Description of the changes in this PR

LP and LCP solvers have been updated so that payoffs are pushed to terminal nodes when filling the sequence form tableau.

@tturocy tturocy requested a review from rahulsavani December 17, 2025 08:50
Copy link
Member

@rahulsavani rahulsavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a scan this looks OK to me. It does have all the relevant xfailing tests from master and from PR #705 now xpassing. I think we should get PR #705 fixed (see requested changes) and merged in master as a next step, before merging this one.

Copy link
Member

@tturocy tturocy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now showing 7 tests as xpassing. So test marking has not been updated as requested.

@tturocy tturocy merged commit 867d2b8 into master Jan 2, 2026
26 checks passed
@tturocy tturocy deleted the update_old_lp_lcp branch January 2, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: adding a "all zero payoff" outcome at a non-terminal node breaks lp_solve and lcp_solve

4 participants