Skip to content

Fix regression in action graph games#859

Draft
tturocy wants to merge 4 commits into
masterfrom
bug_agg
Draft

Fix regression in action graph games#859
tturocy wants to merge 4 commits into
masterfrom
bug_agg

Conversation

@tturocy
Copy link
Copy Markdown
Member

@tturocy tturocy commented Apr 27, 2026

This fixes a regression in action graph games, that was causing a segmentation fault due to not initialising the strategy index correctly after doing so was introduced in a refactor a few months ago.

I have tested this with 2x2.agg and the previous behaviour has been restored.

While we are not planning to do anything major with action graph games for 17.0, this would be a good opportunity for us to add some entries into the test suite just to guard against regressions on the limited set of AGG files we currently have.

@tturocy tturocy added this to the gambit-16.7.0 milestone Apr 27, 2026
@tturocy tturocy marked this pull request as draft April 27, 2026 14:46
Copy link
Copy Markdown
Member

@rahulsavani rahulsavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the fix seems to work fine.

I will now add tests and then ask @tturocy to review those.....

@tturocy
Copy link
Copy Markdown
Member Author

tturocy commented May 14, 2026

I've now added support for outcomes in (Bayesian) AGGs in Python, which indirectly solves the .to_arrays() problem (and also #871)

@tturocy
Copy link
Copy Markdown
Member Author

tturocy commented May 28, 2026

@rahulsavani In view of the discussion in #879, would it make sense only to run tests in floating-point for the purposes of considering the regression identified in this PR as "fixed"? The broader issue of the semantics of numerical data types in (B)AGGs has always been there (we have just never thought carefully about it), so the fix in this PR would at least restore us to the world before the bug was introduced.

The plan in #879 would then point towards further tests to add in due course.

@rahulsavani
Copy link
Copy Markdown
Member

@rahulsavani In view of the discussion in #879, would it make sense only to run tests in floating-point for the purposes of considering the regression identified in this PR as "fixed"? The broader issue of the semantics of numerical data types in (B)AGGs has always been there (we have just never thought carefully about it), so the fix in this PR would at least restore us to the world before the bug was introduced.

The plan in #879 would then point towards further tests to add in due course.

Absolutely, that's what I had in mind and planned to discuss with you. I will update the tests accordingly asap.

@rahulsavani rahulsavani self-assigned this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants