Skip to content

Use catalog games for tests#869

Merged
tturocy merged 6 commits into
masterfrom
games_test_catalog
May 19, 2026
Merged

Use catalog games for tests#869
tturocy merged 6 commits into
masterfrom
games_test_catalog

Conversation

@tturocy
Copy link
Copy Markdown
Member

@tturocy tturocy commented May 7, 2026

This removes some games which were still in test_games, but now have been canonicalised in the catalog.

@rahulsavani rahulsavani self-requested a review May 8, 2026 12:50
Copy link
Copy Markdown
Member

@rahulsavani rahulsavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Bye bye e01.efg and e02.efg.

BTW, while the changes to the test suite look good as part of this review I "grep"ed e01.efg and e02.efg and found references to them in the docs in tools (in tools.enumpoly.rst for e01.efg and in {liap,lcp,simpdiv,enumpure}.rst for e02.efg). Perhaps you could just fix that in this PR.

@tturocy
Copy link
Copy Markdown
Member Author

tturocy commented May 19, 2026

Good point. We don't have a great way to reference those (as paths would depend on the cwd of the shell) but I've done something sensible to make it clear they're catalog games. We'll likely be re-drafting this documentation with the planned reworking of the command-line tools anyway so this should do for present purposes.

@tturocy tturocy merged commit 38108f3 into master May 19, 2026
26 checks passed
@tturocy tturocy deleted the games_test_catalog branch May 19, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants