Add GameSubgame class and subgame API#909
Closed
d-kad wants to merge 12 commits into
Closed
Conversation
…s with no child subgames; add Game.terminal_subgames property
Replace the linear contains() scan over m_subgames with a hash lookup of m_subgameCache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
GameSubgameRepin C++/GameSubgamein Python #585Description of the changes in this PR
Adds
GameSubgameRep(C++) andSubgame(Python), a first-class object representing a subgame, building on the subgame-root detection from 16.6.0 (#584).On
Subgame:.root,.parent(Nonefor the root subgame),.children, and.difference(infosets in this subgame but not in any of its child subgames).On
Game:.root_subgame(Noneif the game has no subgames),.subgames(postorder),.terminal_subgames, and.subgame_root(infoset). Subgames use the same lazy-build/invalidation lifecycle as strategies.Parent/child links live on the
Subgameobject rather than onGameRep, for consistency withnode.parent,infoset.player, etc.; collection-level queries stay onGame.Makes
IsSubgameRoot()O(1) -- closes an old TODO.Not implemented:
GetInfosets(subgame, player)from the description of #585 —differenceis the closest piece (unfiltered by player) -- will be shipped separately as this PR is pretty big already.How to review this PR
src/games/gametree.cc(gametree.h,game.h): detection (Phases 1–2 ofBuildSubgameRoots) is the existing 16.6.0 algorithm; new here is the Phase 3 subgame-tree/difference construction.pytest tests/test_node.py— covers postorder, parent/child, terminal subgames, and the difference partition onsubgame-8-roots.efg, plus the trivial-game edge case.