Claude/plan v3 deployment vp mpw

[gamblecodezcom]

User description

Summary by Sourcery

Tighten Telegram group command handling and deployment notifications while cleaning up dead code and updating project docs and task tracking.

New Features:

• Introduce a BOT_KNOWN_COMMANDS registry to define the full set of bot-owned commands and gate group command handling.
• Add support for ignoring commands explicitly addressed to other bots in group chats based on @mentions.

Bug Fixes:

• Prevent the bot from responding to commands it does not own in shared group chats by filtering against BOT_KNOWN_COMMANDS.
• Fix deployment script behavior when systemd restart fails by adding a manual kill-and-nohup fallback and making disown calls resilient.
• Avoid Markdown rendering issues in Telegram deploy notifications by switching to plain-text, URL-encoded messages.

Enhancements:

• Refine group command middleware to more robustly parse command tokens and optional @mentions before redirecting to DM.
• Remove legacy, unused adminKeyboard promo keyboard implementation from index.js to reduce dead code.
• Expand internal functionality and module mapping docs to reflect new backend, rate limiting, and deployment tooling, and document BOT_KNOWN_COMMANDS maintenance requirements in AI guidelines.

Build:

• Adjust prod-run.sh restart flow to fall back to manual process management and simplify admin deploy notifications.

Documentation:

• Update RUNEWAGER_FUNCTIONALITY_MAP.md, todolist.md, and CLAUDE.md to record the latest audit, merged backend utilities, removed dead code, and add explicit rules for keeping BOT_KNOWN_COMMANDS in sync with command registrations.

Tests:

• Confirm that the existing 60-test suite still passes after cleanup and guard changes, as recorded in the audit docs.

Chores:

• Record the /runewager-audit phase results and merged main-branch infrastructure changes in project documentation and tracking files.

---

CodeAnt-AI Description

Prevent runewager from responding to other bots in group chats; add restart fallback and plain-text deploy notifications

What Changed

• In group/supergroup chats the bot now only reacts to commands it owns; commands addressed to other bots are ignored and unknown commands are silently ignored in groups.
• Commands that should remain group-aware continue to work in groups; all other group commands are redirected to the bot's DM with an "Open DM" button.
• Deployment script now falls back to killing the old process and starting the bot with nohup if systemctl restart fails, and disown calls are made resilient to errors.
• Admin deploy notifications to Telegram are sent as plain-text URL-encoded messages (no Markdown) to avoid rendering errors with logs or special characters.
• Removed an unused legacy promo keyboard function and added explicit documentation requiring the BOT_KNOWN_COMMANDS list to stay synchronized with command registrations.

Impact

✅ Fewer mistaken bot replies in shared groups
✅ More reliable restarts when systemd restart fails
✅ Clearer deploy notifications for admins

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai]

CodeAnt AI is reviewing your PR.

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[sourcery-ai]

Reviewer's Guide

Adds a centralized BOT_KNOWN_COMMANDS allowlist and tighter group-command parsing/ownership checks, hardens the deploy script’s restart and Telegram notification behavior, removes a dead admin keyboard helper, and updates the audit/docs/todo metadata to reflect the latest v3.1 runtime and tooling layout.

Sequence diagram for updated group command guard and BOT_KNOWN_COMMANDS handling

sequenceDiagram
    actor User
    participant TelegramServer
    participant Bot
    participant GroupCommandGuardMiddleware
    participant CommandHandler

    User->>TelegramServer: Send message in group (e.g. /link@runewager_bot arg1)
    TelegramServer->>Bot: Deliver update
    Bot->>GroupCommandGuardMiddleware: ctx (message.text starts with /)

    GroupCommandGuardMiddleware->>GroupCommandGuardMiddleware: Extract cmdToken, rawCmd, mentionedBot
    GroupCommandGuardMiddleware->>GroupCommandGuardMiddleware: ourUsername = ctx.botInfo.username

    alt Command targets a different bot
        GroupCommandGuardMiddleware-->>Bot: return next()
        Bot->>CommandHandler: Other middleware or handlers continue
    else Command not owned by this bot
        GroupCommandGuardMiddleware->>GroupCommandGuardMiddleware: Check BOT_KNOWN_COMMANDS.has(rawCmd)
        GroupCommandGuardMiddleware-->>Bot: return next() (ignore unknown command)
    else Command is owned by this bot
        GroupCommandGuardMiddleware->>GroupCommandGuardMiddleware: Check GROUP_PASSTHROUGH_COMMANDS.has(rawCmd)
        alt Group passthrough command
            GroupCommandGuardMiddleware-->>Bot: next() (handle in group)
            Bot->>CommandHandler: Execute group-aware handler
        else Non passthrough command in group
            GroupCommandGuardMiddleware-->>Bot: Redirect to DM
            Bot->>TelegramServer: Send DM redirect message to user
        end
    end

Loading

Flow diagram for hardened prod-run restart and Telegram notification

flowchart TD
    A[Start prod-run.sh deploy] --> B{Existing PID found?}
    B -->|Yes| C[Record PID]
    B -->|No| D[PID empty]

    C --> E{systemctl available and service file exists?}
    D --> E

    E -->|Yes| F[Attempt systemctl restart runewager.service]
    E -->|No| K[Kill existing PID if any]

    F -->|Success| G[systemd managed restart]
    F -->|Failure| H[Warn and fallback to manual restart]

    H --> I[Kill existing PID if any]
    I --> J[Sleep 1s and start node index.js via nohup]
    J --> L[disown or ignore error]
    G --> M[Sleep 3s and refresh PID]
    L --> M

    K --> N[Start node index.js via nohup]
    N --> O[disown or ignore error]
    O --> M

    M --> P[Run health checks on HEALTH_PORT]
    P --> Q[Compute HEALTH_STATUS and SYSTEMD_ACTIVE]

    Q --> R{ADMIN_IDS and TELEGRAM_BOT_TOKEN set?}
    R -->|No| S[Skip Telegram notification]
    R -->|Yes| T[Build plain text message _MSG with health, port, PID, systemd]

    T --> U[Loop over each admin id]
    U --> V[Send Telegram sendMessage via curl
--data-urlencode chat_id and text
no parse_mode]
    V --> W[Ignore curl errors]

    S --> X[Deploy script complete]
    W --> X

Loading

File-Level Changes

Change	Details	Files
Introduce BOT_KNOWN_COMMANDS and stricter group command routing so the bot only handles its own commands and respects explicit @bot mentions in group chats.	Define BOT_KNOWN_COMMANDS set as the authoritative list of commands this bot owns. Refine command parsing middleware to split the first token, extract optional @mention, and normalize the raw command name. Ignore commands explicitly addressed to a different bot username based on ctx.botInfo.username. Skip handling of any command not present in BOT_KNOWN_COMMANDS to avoid intercepting other bots’ commands. Keep GROUP_PASSTHROUGH_COMMANDS as a subset used to bypass DM redirection while all other known commands in groups get the DM redirect behavior.	index.js
Harden prod deployment script restart logic and simplify Telegram deploy notifications to a safe, plain-text message.	Wrap systemctl restart in an error check and, on failure, fall back to killing the old PID and starting index.js via nohup. Ensure disown calls are tolerant of errors using "
Remove unused legacy admin promo keyboard helper and reflect its removal and new infra modules in documentation and tracking files.	Delete the dead adminKeyboard() function and its accompanying comment block from index.js. Update RUNEWAGER_FUNCTIONALITY_MAP.md to reflect new runtime modules (telegramSafe.js, rateLimiter.js, backend.js, systemd service for backend) and script set, and record the latest audit outcomes and merged changes. Document the mandatory BOT_KNOWN_COMMANDS synchronization rule in both RUNEWAGER_FUNCTIONALITY_MAP.md and CLAUDE.md to guide future changes. Refresh todolist.md with the resolved dead-code bug entry and updated last-updated blurb tied to the audit and main-merge work.	index.js RUNEWAGER_FUNCTIONALITY_MAP.md todolist.md CLAUDE.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Warning

Rate limit exceeded

@gamblecodezcom has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0749530-86bf-49f4-9b9d-efa9015a5bbc

📥 Commits

Reviewing files that changed from the base of the PR and between 939ab4d and b516247.

📒 Files selected for processing (5)

• CLAUDE.md
• RUNEWAGER_FUNCTIONALITY_MAP.md
• index.js
• prod-run.sh
• todolist.md

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch claude/plan-v3-deployment-VPMpw

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey - I've left some high level feedback:

• The new BOT_KNOWN_COMMANDS list is a single large manual source of truth; consider adding a small runtime guard (e.g., in your bot.command() helper) that asserts each registered command exists in the set so drift is caught immediately rather than relying only on process discipline.
• The command parsing logic in the group guard middleware (extracting rawCmd and mentionedBot) is now non-trivial; if other parts of the code need to interpret commands, consider extracting this into a shared helper to avoid future divergence in how commands and @mentions are parsed.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new BOT_KNOWN_COMMANDS list is a single large manual source of truth; consider adding a small runtime guard (e.g., in your bot.command() helper) that asserts each registered command exists in the set so drift is caught immediately rather than relying only on process discipline.
- The command parsing logic in the group guard middleware (extracting rawCmd and mentionedBot) is now non-trivial; if other parts of the code need to interpret commands, consider extracting this into a shared helper to avoid future divergence in how commands and @mentions are parsed.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codeant-ai]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Sensitive info exposure The deploy notification uses curl to call the Telegram Bot API. The bot token is included in the request URL (adjacent to the added data-urlencode lines). URLs passed to command arguments can be visible to other users via process listings or /proc, risking token exposure. Consider alternatives that avoid placing the token directly in the command line or move sending into a short-lived helper process that reads the token from a protected file or invokes a library. Systemd race If systemctl restart fails the script falls back to manually killing the PID and launching a nohup process while systemd may still be attempting to manage the service. That can produce duplicate node processes or cause systemd to re-spawn the service unexpectedly. Consider ensuring systemd has stopped/manually disabling before starting the fallback, or prefer stopping the systemd unit first to avoid races.

[codeant-ai]

Suggestion: The deploy notification now reads only TELEGRAM_BOT_TOKEN from .env, but the project treats BOT_TOKEN as the canonical name and TELEGRAM_BOT_TOKEN as a legacy alias, so in environments where only BOT_TOKEN is set (the default), Telegram deploy notifications will silently never send. [logic error]

Severity Level: Major ⚠️

- ⚠️ Prod-run Telegram deploy summaries never send with only BOT_TOKEN.
- ⚠️ Admins lose automated deploy/health visibility; must check logs manually.

Suggested change

	_BOT_TOKEN="$(read_env_value TELEGRAM_BOT_TOKEN || true)"
	_BOT_TOKEN="$(read_env_value BOT_TOKEN || true)"
	[[ -z "$_BOT_TOKEN" ]] && _BOT_TOKEN="$(read_env_value TELEGRAM_BOT_TOKEN || true)"

Steps of Reproduction ✅

1. Configure `.env` in the project root (`/workspace/Runewager/.env`) using `.env.example`
as a template (`.env.example:12` shows `BOT_TOKEN=`, `:37` shows `TELEGRAM_BOT_TOKEN=`)
and set a valid `BOT_TOKEN` plus a comma‑separated `ADMIN_IDS` (as documented by
`README.md:15` and `:26`), but leave `TELEGRAM_BOT_TOKEN` unset or empty.

2. Run the deployment runner `prod-run.sh` (the main production deploy script whose
post‑deploy health + Telegram reporting logic starts around the `# 11) POST-START HEALTH
CHECK + TELEGRAM REPORT` section in `prod-run.sh`), so it reaches the end of the script
after starting/restarting the bot.

3. At the Telegram notification block in `prod-run.sh` lines `558–563`, `_ADMIN_IDS` is
populated from `.env` via `read_env_value ADMIN_IDS` (line `558`), but `_BOT_TOKEN` is set
only from `read_env_value TELEGRAM_BOT_TOKEN` (line `559`), which returns an empty string
because only `BOT_TOKEN` is defined in `.env`.

4. Because `_BOT_TOKEN` is empty, the guard `if [[ -n "$_BOT_TOKEN" && -n "$_ADMIN_IDS"
]]; then` (line `560`) evaluates to false, the `curl` loop to
`https://api.telegram.org/bot${_BOT_TOKEN}/sendMessage` (lines `564–567`) is never
executed, and no Telegram deploy/health notification is sent to any `ADMIN_IDS`, despite
the project treating `BOT_TOKEN` as canonical (see `index.js:14` and documentation notes
in `CLAUDE_FIX_PR.md:2474–2483`).

Prompt for AI Agent 🤖

This is a comment left during a code review.

**Path:** prod-run.sh
**Line:** 559:559
**Comment:**
	*Logic Error: The deploy notification now reads only `TELEGRAM_BOT_TOKEN` from `.env`, but the project treats `BOT_TOKEN` as the canonical name and `TELEGRAM_BOT_TOKEN` as a legacy alias, so in environments where only `BOT_TOKEN` is set (the default), Telegram deploy notifications will silently never send.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

👍 | 👎

[codeant-ai]

CodeAnt AI finished reviewing your PR.