Skip to content

Retry publication before reporting build as failure.#80

Merged
webbertakken merged 1 commit intomainfrom
robustify-publication-flow
Feb 16, 2021
Merged

Retry publication before reporting build as failure.#80
webbertakken merged 1 commit intomainfrom
robustify-publication-flow

Conversation

@webbertakken
Copy link
Copy Markdown
Member

@webbertakken webbertakken commented Feb 16, 2021

Changes

  • This duplicates build and publish step, executed only when it fails initially.
  • I expect that 90% or more of the failures should be mitigated in this way, in particular:
    • Failure during the build phase, where some dependency download isn't received properly
    • Connection interrupted while pushing the image to dockerhub
    • Failure with one of the calls to apply one of the tags

Considered alternatives

  • Added this use case as rationale to github community thread about retrying steps. Ideally we'd just set the step to retry up to 2 times instead of duplicating all this code.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@github-actions
Copy link
Copy Markdown

Cat Gif

@webbertakken webbertakken merged commit ee02c92 into main Feb 16, 2021
@webbertakken webbertakken deleted the robustify-publication-flow branch February 16, 2021 00:18
@mob-sakai mob-sakai mentioned this pull request Feb 16, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant