Skip to content

Change customBuildprofile to activeBuildProfile and improve validation #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Change customBuildprofile to activeBuildProfile and improve validation #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions example/BuildScript.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public static void BuildWithProfile()
Dictionary<string, string> options = GetValidatedOptions();

// Load build profile from Assets folder
BuildProfile buildProfile = AssetDatabase.LoadAssetAtPath<BuildProfile>(options["customBuildProfile"]);
BuildProfile buildProfile = AssetDatabase.LoadAssetAtPath<BuildProfile>(options["activeBuildProfile"]);

// Set it as active
BuildProfile.SetActiveBuildProfile(buildProfile);
Expand Down Expand Up @@ -134,16 +134,18 @@ private static Dictionary<string, string> GetValidatedOptions()
EditorApplication.Exit(110);
}

if (!validatedOptions.TryGetValue("buildTarget", out string buildTarget))
if (validatedOptions.TryGetValue("buildTarget", out var buildTarget))
{
Console.WriteLine("Missing argument -buildTarget");
EditorApplication.Exit(120);
if (!Enum.IsDefined(typeof(BuildTarget), buildTarget ?? string.Empty))
{
Console.WriteLine($"{buildTarget} is not a defined {nameof(BuildTarget)}");
EditorApplication.Exit(121);
}
}

if (!Enum.IsDefined(typeof(BuildTarget), buildTarget ?? string.Empty))
else if (!validatedOptions.TryGetValue("activeBuildProfile", out string _))
{
Console.WriteLine($"{buildTarget} is not a defined {nameof(BuildTarget)}");
EditorApplication.Exit(121);
Console.WriteLine("Missing argument -buildTarget or -activeBuildProfile");
EditorApplication.Exit(120);
}

if (!validatedOptions.TryGetValue("customBuildPath", out string _))
Expand Down