Pin to working unity-3d image

action.yml

@@ -40,7 +40,7 @@ inputs:
     description: 'The android versionCode'
   androidAppBundle:
     required: false
-    default: false
+    default: 'false'
     description: 'Whether to build .aab instead of .apk'
   androidKeystoreName:
     required: false

action/Dockerfile

@@ -1,5 +1,5 @@
 ARG IMAGE
-FROM $IMAGE
+FROM registry.gitlab.com/szymonkaz/unity3d:2019.3.12f1-android-szymon-kaz-fixfailingandroidgithubactions
 
 LABEL "com.github.actions.name"="Unity - Builder"
 LABEL "com.github.actions.description"="Build Unity projects for different platforms."

src/model/input.js

@@ -46,9 +46,9 @@ class Input {
   }
 
   static get androidAppBundle() {
-    const input = core.getInput('androidAppBundle') || 'false';
+    const input = core.getInput('androidAppBundle') || false;
 
-    return input === 'true' ? 'true' : 'false';
+    return input === 'true';
   }
 
   static get androidKeystoreName() {
@@ -72,9 +72,9 @@ class Input {
   }
 
   static get allowDirtyBuild() {
-    const input = core.getInput('allowDirtyBuild') || 'false';
+    const input = core.getInput('allowDirtyBuild') || false;
 
-    return input === 'true' ? 'true' : 'false';
+    return input === 'true';
   }
 
   static get customParameters() {

src/model/input.test.js

@@ -133,18 +133,18 @@ describe('Input', () => {
 
   describe('androidAppBundle', () => {
     it('returns the default value', () => {
-      expect(Input.androidAppBundle).toStrictEqual('false');
+      expect(Input.androidAppBundle).toStrictEqual(false);
     });
 
     it('returns true when string true is passed', () => {
       const spy = jest.spyOn(core, 'getInput').mockReturnValue('true');
-      expect(Input.androidAppBundle).toStrictEqual('true');
+      expect(Input.androidAppBundle).toStrictEqual(true);
       expect(spy).toHaveBeenCalledTimes(1);
     });
 
     it('returns false when string false is passed', () => {
       const spy = jest.spyOn(core, 'getInput').mockReturnValue('false');
-      expect(Input.androidAppBundle).toStrictEqual('false');
+      expect(Input.androidAppBundle).toStrictEqual(false);
       expect(spy).toHaveBeenCalledTimes(1);
     });
   });
@@ -216,18 +216,18 @@ describe('Input', () => {
 
   describe('allowDirtyBuild', () => {
     it('returns the default value', () => {
-      expect(Input.allowDirtyBuild).toStrictEqual('false');
+      expect(Input.allowDirtyBuild).toStrictEqual(false);
     });
 
     it('returns true when string true is passed', () => {
       const spy = jest.spyOn(core, 'getInput').mockReturnValue('true');
-      expect(Input.allowDirtyBuild).toStrictEqual('true');
+      expect(Input.allowDirtyBuild).toStrictEqual(true);
       expect(spy).toHaveBeenCalledTimes(1);
     });
 
     it('returns false when string false is passed', () => {
       const spy = jest.spyOn(core, 'getInput').mockReturnValue('false');
-      expect(Input.allowDirtyBuild).toStrictEqual('false');
+      expect(Input.allowDirtyBuild).toStrictEqual(false);
       expect(spy).toHaveBeenCalledTimes(1);
     });
   });

src/model/versioning.js

@@ -10,7 +10,7 @@ export default class Versioning {
   }
 
   static get isDirtyAllowed() {
-    return Input.allowDirtyBuild === 'true';
+    return Input.allowDirtyBuild;
   }
 
   static get strategies() {