-
Notifications
You must be signed in to change notification settings - Fork 7
Interface update #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
solliolli
merged 111 commits into
gamma-opt:interface-update
from
helmihankimaa:interface-influence-diagram
Sep 28, 2021
Merged
Interface update #27
solliolli
merged 111 commits into
gamma-opt:interface-update
from
helmihankimaa:interface-influence-diagram
Sep 28, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a/DecisionProgramming.jl into interface-influence-diagram pulling from origin before push.
…d all its sub-structs. Adjusted the datatypes in InfluenceDiagram accordingly.
…ion AddNode! and changed validate_node accordingly. Commented out old definitions of these structs.
…ram! to work with the new datatypes and structs.
…l we decide how we want to implement these.
…ed primitive types.
…d second in StateProbabilities.
…nspecified types caused errors due to the .= broadcasting in some cases.
…is if the influence diagram does not have value nodes, or the value node has been erroneously put into the I_j of some other node, then we don't want it to produce this error message but the correct one under this one.
Added a length function to path compatibility variables (AbstractDict) so it prints nicely at least in Atom
…o called by node and state indices if wanted. For instance in testing.
…d for chance nodes and utilities only for value nodes.
…a/DecisionProgramming.jl into interface-influence-diagram Pulled one line chance so that I can push.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is still in the works, feel free to leave comments and feedback.
In this pull request the user interface has been thoroughly changed. Also, in the backend the influence diagram information has been reorganised into an influence diagram structure, which has some effects on the other sections of the code as well.