Improve illuminator integration tests#1940
Merged
tobiaskleiner merged 14 commits intomainfrom Jan 8, 2026
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
GernotMaier
approved these changes
Jan 8, 2026
Contributor
GernotMaier
left a comment
GernotMaier
left a comment
There was a problem hiding this comment.
Thanks! Very minor comment (in two integration test files), already approved.
| - "Total number of photons produced in this run" | ||
| - "Sim_telarray finished at" | ||
| - "CORSIKA IACT finished at" | ||
| - "Tel. triggered: " |
Contributor
There was a problem hiding this comment.
Are these spaces needed? I am not sure if this is good.
Collaborator
Author
There was a problem hiding this comment.
Spaces are there in the log, but not needed as this is the only occurence of the pattern. Removed.
|
Collaborator
Author
|
Thanks for the review @GernotMaier! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pattern search in logfiles during integration tests.
Fix bug when isotropic is used for angular distribution and width 0 is falsely added.