Image naming with software versions#1984
Merged
GernotMaier merged 5 commits intomainfrom Jan 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the naming convention for simtools-prod Docker images and refactors the build matrix to better support combinations of simtools, CORSIKA, and sim_telarray versions.
Changes:
- Changed matrix from nested dictionary to separate dimensions (corsika, sim_telarray, avx_flag)
- Updated image tag suffix format to include all version components
- Removed pull_request from push condition (now only pushes on release, main branch, or manual dispatch)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/changes/1984.api.md | Documents the new naming convention for simtools-prod images |
| .github/workflows/build-simtools-prod.yml | Refactors build matrix and updates image tagging with new naming scheme |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
tobiaskleiner
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review after #1983
Update naming of simtools-prod images to
<simtools version>-<corsika version>-<sim_telarray version>-<avx option>.Improve the matrix in the workflow to allow combinations of simtools, CORSIKA, and sim_telarray.