Add simtools log file to grid output.#2040
Merged
GernotMaier merged 4 commits intomainfrom Feb 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the simtools application log file to the per-model grid upload tarballs, so grid outputs include the full simtools runtime context (and adjusts the simulate-prod app label/logging sequence accordingly).
Changes:
- Add
get_simtools_log_file()helper to discover an attachedlogging.FileHandlerlog path (walking logger parents). - Include the discovered simtools log file in
Simulator.pack_for_register()tarball contents. - Update
simulate_prodto set an application label and emitreport()before packing, plus add a changelog entry and unit tests for the new helper.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/simtools/utils/general.py |
Adds helper to locate the simtools log file from logger handlers. |
src/simtools/simulator.py |
Adds simtools log file to per-model grid tarball packaging. |
src/simtools/applications/simulate_prod.py |
Sets application label for consistent log naming; moves report() earlier so it’s captured before packing. |
tests/unit_tests/utils/test_general.py |
Adds unit tests for get_simtools_log_file(). |
docs/changes/2040.feature.md |
Documents the new behavior in the changelog. |
|
Contributor
Author
|
@EshitaJoshi - this is a direct follow up to #2039 |
Contributor
Author
|
And thanks again @EshitaJoshi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add simtools log file to grid output tar package.
Note that the simtools log file will be included in the tar package for each model version. I guess this duplication if acceptable.