Increase number of photons for testing#2045
Merged
GernotMaier merged 3 commits intomainfrom Feb 13, 2026
Merged
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the default number of flasher photons used when test=True in the light-emission simulator to make MST-related tests more reliable (ensuring sufficient light / triggers).
Changes:
- Increase test-mode
flasher_photonsdefault from1e5to1e6in the simulator. - Update the corresponding unit test expectation.
- Add a changelog entry documenting the adjustment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/unit_tests/simtel/test_simulator_light_emission.py |
Updates the test-mode assertion to expect 1e6 photons. |
src/simtools/simtel/simulator_light_emission.py |
Raises the test-mode fallback for flasher_photons to 1e6. |
docs/changes/2045.bugfix.md |
Documents the photon-count increase for test cases. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
tobiaskleiner
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase number of flasher photons for tests cases from 1.e5 to 1.e6 to ensure light / triggers in MSTs.