Skip to content

Compact numeric lists#2114

Merged
GernotMaier merged 3 commits into
mainfrom
compact-numeric-lists
Apr 13, 2026
Merged

Compact numeric lists#2114
GernotMaier merged 3 commits into
mainfrom
compact-numeric-lists

Conversation

@GernotMaier
Copy link
Copy Markdown
Contributor

In #2088 we introduce a format change to the JSON output for numerical lists to increase readability for table-style dicts.

Noticed now only (obviously) that this affects all lists numerical lists, which interferes with the way we check that all model parameters are changed using the info-change files only. CI failure e.g., here.

This PR applies the compact writing for dict-style values only (and leave normal lists as before).

If you are really interested - we want the first and not the second format (otherwise we have to rewrite our CI or update many model parameter json files in the simulation models repository):

@@ -16,11 +16,5 @@
         null,
         null
     ],
-    "value": [
-        1,
-        0.00231,
-        4.38113,
-        3.38831,
-        1.43381
-    ]
+    "value": [1, 0.00231, 4.38113, 3.38831, 1.43381]
 }

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread src/simtools/io/ascii_handler.py
Comment thread docs/changes/2114.maintenance.md Outdated
@GernotMaier GernotMaier marked this pull request as ready for review April 13, 2026 10:46
@GernotMaier GernotMaier requested a review from EshitaJoshi April 13, 2026 10:46
@ctao-sonarqube
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@EshitaJoshi EshitaJoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@GernotMaier
Copy link
Copy Markdown
Contributor Author

Thanks for the review @EshitaJoshi

@GernotMaier GernotMaier merged commit f743f20 into main Apr 13, 2026
17 checks passed
@GernotMaier GernotMaier deleted the compact-numeric-lists branch April 13, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants