Compact numeric lists#2114
Merged
Merged
Conversation
|
Contributor
Author
|
Thanks for the review @EshitaJoshi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




In #2088 we introduce a format change to the JSON output for numerical lists to increase readability for table-style dicts.
Noticed now only (obviously) that this affects all lists numerical lists, which interferes with the way we check that all model parameters are changed using the info-change files only. CI failure e.g., here.
This PR applies the compact writing for dict-style values only (and leave normal lists as before).
If you are really interested - we want the first and not the second format (otherwise we have to rewrite our CI or update many model parameter json files in the simulation models repository):