Add model_status keywords to SimulationModelsInfo schema.#2116
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SimulationModelsInfo JSON schema used to validate simulation model info.yml files, introducing a model_status field and adding unit tests to ensure the new constraints and backward compatibility behavior.
Changes:
- Add schema version
0.2.0forsimulation_models_infoand require a newmodel_statusfield with an allowed-value enum. - Keep schema version
0.1.0embedded in the same schema file for backward compatibility. - Add unit tests covering accepted/rejected
model_statusvalues and compatibility withschema_version: 0.1.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/simtools/schemas/simulation_models_info.schema.yml |
Adds new schema document (v0.2.0) introducing required model_status enum while retaining v0.1.0. |
tests/unit_tests/data_model/test_schema.py |
Adds tests validating model_status allowed values, rejection of invalid values, and compatibility across schema versions. |
docs/changes/2116.feature.md |
Towncrier fragment documenting the schema feature addition. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
tobiaskleiner
approved these changes
Apr 15, 2026
Collaborator
tobiaskleiner
left a comment
There was a problem hiding this comment.
Thanks for the PR @GernotMaier!
Contributor
Author
|
Thanks @tobiaskleiner ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




see discussion in simulation models repo
Additional fix and improvements for reading schema files. Generalize the schema_version fields.
For all other changes - see the Copilot summary, which is better than I would have written...