Allow to to set workflow git tag from command line for maintain_simulation_model_add_production#2120
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CLI override to select the git tag/branch used for downloading model parameters when running maintain_simulation_model_add_production, allowing maintenance workflows to bypass the info.yml default.
Changes:
- Extend
model_repository.generate_new_production()to accept an optionalsetting_workflows_git_tagoverride (fallback remainsinfo.yml/"main"). - Add
--setting_workflows_git_tagflag tomaintain_simulation_model_add_productionand pass it through to the repository logic. - Add a unit test covering the override behavior and a changelog entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/simtools/model/model_repository.py |
Adds optional setting_workflows_git_tag parameter and fallback logic. |
src/simtools/applications/maintain_simulation_model_add_production.py |
Registers new CLI flag and forwards it into generate_new_production(). |
tests/unit_tests/model/test_model_repository.py |
Adds a unit test verifying CLI-provided git tag overrides info.yml. |
docs/changes/2120.maintenance.md |
Documents the maintenance change in the changelog. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
tobiaskleiner
approved these changes
Apr 16, 2026
Collaborator
tobiaskleiner
left a comment
There was a problem hiding this comment.
Thanks @GernotMaier!
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Small change to simplify the usage of
maintain_simulation_model_add_productionduring maintenance: allow to set the git tag for the setting workflow repository from command line.(some changes were also requested to tmp path in the tests)