Skip to content

Use dotenv linter action instead of direct install and download#2144

Merged
GernotMaier merged 3 commits into
mainfrom
dotenv-linter-action
Apr 29, 2026
Merged

Use dotenv linter action instead of direct install and download#2144
GernotMaier merged 3 commits into
mainfrom
dotenv-linter-action

Conversation

@GernotMaier
Copy link
Copy Markdown
Contributor

@GernotMaier GernotMaier commented Apr 29, 2026

Maybe this solves the issue of e.g. https://github.com/gammasim/simtools/actions/runs/25103673807/job/73559252311 (seen a couple of times now).

There is also a pre-commit tool for dotenv linter, but this requires to have docker installed (which I don't want to assume on any developer machine; e.g., I have podman).

@GernotMaier GernotMaier self-assigned this Apr 29, 2026
@GernotMaier GernotMaier marked this pull request as ready for review April 29, 2026 10:46
@GernotMaier GernotMaier added the Skip review PR without required review label Apr 29, 2026
@GernotMaier GernotMaier requested a review from Copilot April 29, 2026 10:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI linting workflow to run dotenv-linter via the maintained GitHub Action instead of downloading/installing it manually, aiming to reduce intermittent CI failures during install.

Changes:

  • Replace curl | sh installation of dotenv-linter with dotenv-linter/action-dotenv-linter@v2 in the linter workflow.
  • Add a changelog fragment documenting the maintenance change.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/changes/2144.maintenance.md Adds a changelog note for the CI linting adjustment.
.github/workflows/CI-linter.yml Switches dotenv linting to the official action to avoid direct download/install.
Comments suppressed due to low confidence (1)

docs/changes/2144.maintenance.md:2

  • This changelog fragment should be a single non-empty line; currently the file contains an extra blank line after the entry, which can violate the “one-line fragment” convention/checks. Please remove the trailing empty line so the fragment is exactly one line.
Use github action for dotenv linter instead direct installation and call.

Comment thread docs/changes/2144.maintenance.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ctao-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@GernotMaier GernotMaier merged commit 19bde71 into main Apr 29, 2026
16 checks passed
@GernotMaier GernotMaier deleted the dotenv-linter-action branch April 29, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip review PR without required review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants