Remove run_mode setup in simulate_illuminator to avoid user confusion.#2158
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the user-facing run_mode setup from simtools-simulate-illuminator and shifts the illuminator/flasher mode inference into SimulatorLightEmission, so the CLI behavior follows the calibration model instead of a hardcoded app override.
Changes:
- Stop injecting
run_mode="illuminator"in the illuminator application entry point. - Infer
run_modefrom the calibration model’sflasher_typewhen the caller did not provide one. - Update unit tests around
_initialize_light_emission_configurationand add a changelog fragment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/simtools/applications/simulate_illuminator.py |
Removes the hardcoded run_mode from the illuminator CLI flow. |
src/simtools/simtel/simulator_light_emission.py |
Infers run_mode from flasher_type during light-emission config initialization. |
tests/unit_tests/simtel/test_simulator_light_emission.py |
Extends unit coverage for inferred/preserved run_mode behavior. |
docs/changes/2158.maintenance.md |
Adds the changelog entry for the maintenance change. |
|
orelgueta
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
run_modesetup in simulate_illuminator to avoid user confusion. Setrun_modedepending onflasher_type.Closes #2087.