Update layout names for South beta layouts in production model 7.0.0.#2164
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates integration test workflow configs to use version-dependent array layout names, aligning South “alpha/beta” layouts with the renamed CTAO layout identifiers introduced for production model 7.0.0.
Changes:
- Switched several
simtools-simulate-prodintegration test configs from a singlearray_layout_namestring to aby_versionmapping (<7.0.0vs>=7.0.0). - Updated expected output filenames in the “multiple model versions” South gamma config (currently inconsistent with the model versions under test).
- Added a changelog fragment documenting the layout-name update.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration_tests/config/simulate_prod_gamma_62_deg_south_check_output.yml | Use array_layout_name.by_version to map beta → CTAO-South-Beta for model_version >= 7.0.0. |
| tests/integration_tests/config/simulate_prod_gamma_40_deg_south_corsika_only.yml | Same by_version mapping for the South beta layout. |
| tests/integration_tests/config/simulate_prod_gamma_40_deg_south_check_output.yml | Same by_version mapping for the South beta layout. |
| tests/integration_tests/config/simulate_prod_gamma_20_deg_south_multiple_model_versions.yml | Introduce by_version mapping for South alpha layout, but expected output filenames were changed inconsistently for 6.x model versions. |
| docs/changes/2164.model.md | Changelog fragment for the layout-name update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(a bit cumbersome)