Reintroducing Site reports#2166
Conversation
EshitaJoshi
added
no-changelog-needed
GernotMaier
left a comment
GernotMaier
left a comment
There was a problem hiding this comment.
Thanks for this - two minor requests.
There was a problem hiding this comment.
We do not want a lot of functional code in the application scripts. Can you move those new functions into a module?
It is probably either src/simtools/visualization/plot_array_layout.py or src/simtools/layout/array_layout_utils.py.
There was a problem hiding this comment.
Done, moved to src/simtools/visualization/plot_array_layout.py
| file.write("\n") | ||
| version = self.model_version.replace(".", "-") | ||
| filename = f"OBS-{self.site}_{layout_name}_{version}.png" | ||
| version = self.model_version[:3] |
There was a problem hiding this comment.
Remind me: did we decide to plot only major.minor and not patch versions? This is probably the only place where this is the case.
|
|
@GernotMaier Can you have another look at this please and let me know if it's ok to merge? |
GernotMaier
left a comment
GernotMaier
left a comment
There was a problem hiding this comment.
Thanks - looks good.
Someone else might not be able to sleep because of the mix of underscore and hyphens (e.g. in array_layout_subsystem_msts_North_ground_6-0-2.png). I don't mind.
The issue is that when we have a filename ending with |
Yes - but you could use consistently underscores |
2 participants
Associated MR on gitlab: https://gitlab.cta-observatory.org/cta-science/simulations/simulation-model/simulation-models/-/merge_requests/126 .
The reports here were generated using this branch.