Skip to content

Minor HTCondor run scripts improvements#2170

Merged
GernotMaier merged 7 commits into
mainfrom
htcondor-improvements
May 6, 2026
Merged

Minor HTCondor run scripts improvements#2170
GernotMaier merged 7 commits into
mainfrom
htcondor-improvements

Conversation

@GernotMaier
Copy link
Copy Markdown
Contributor

Minor updates:

  • check that apptainer image actually exists (otherwise jobs will be in "H" state, and one has to find the log files for debugging)
  • replace test_layout in integration test file (which does not exist anymore)

@GernotMaier GernotMaier self-assigned this May 6, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the HTCondor submission script generation workflow by adding a pre-flight check for the configured Apptainer image file and updating an integration-test configuration to use a version-dependent array layout name.

Changes:

  • Add an existence check for the configured Apptainer image before generating HTCondor submit/run scripts.
  • Extend unit tests to cover the new “missing image” failure mode.
  • Update an integration-test config to use array_layout_name.by_version instead of the removed test_layout.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/simtools/job_execution/htcondor_script_generator.py Validate apptainer_image exists and pass a Path through to submit-file generation.
tests/unit_tests/job_execution/test_htcondor_script_generator.py Add coverage for the new image existence check (success + failure cases).
tests/integration_tests/config/simulate_prod_htcondor_generator_gamma_20_deg_north.yml Replace obsolete array_layout_name with a version-dependent mapping.

Comment thread src/simtools/job_execution/htcondor_script_generator.py Outdated
Comment thread src/simtools/job_execution/htcondor_script_generator.py
GernotMaier and others added 2 commits May 6, 2026 14:17
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ctao-sonarqube
Copy link
Copy Markdown

ctao-sonarqube Bot commented May 6, 2026

@GernotMaier GernotMaier marked this pull request as ready for review May 6, 2026 12:52
@GernotMaier GernotMaier requested a review from EshitaJoshi May 6, 2026 12:52
@GernotMaier GernotMaier merged commit c5667c9 into main May 6, 2026
19 checks passed
@GernotMaier GernotMaier deleted the htcondor-improvements branch May 6, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants