Minor HTCondor run scripts improvements#2170
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the HTCondor submission script generation workflow by adding a pre-flight check for the configured Apptainer image file and updating an integration-test configuration to use a version-dependent array layout name.
Changes:
- Add an existence check for the configured Apptainer image before generating HTCondor submit/run scripts.
- Extend unit tests to cover the new “missing image” failure mode.
- Update an integration-test config to use
array_layout_name.by_versioninstead of the removedtest_layout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/simtools/job_execution/htcondor_script_generator.py | Validate apptainer_image exists and pass a Path through to submit-file generation. |
| tests/unit_tests/job_execution/test_htcondor_script_generator.py | Add coverage for the new image existence check (success + failure cases). |
| tests/integration_tests/config/simulate_prod_htcondor_generator_gamma_20_deg_north.yml | Replace obsolete array_layout_name with a version-dependent mapping. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
EshitaJoshi
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Minor updates: