Test sources v2#2214
Merged
Merged
Conversation
Add workflow configs to fetch the following test resource files from the simulation model database instead of storing them in the repository: - pm_photoelectron_spectrum.config.yml: spe_LST_2022-04-27_AP2.0e-4.dat (pm_photoelectron_spectrum v2.0.0, LSTN-design) - mirror_list.config.yml: mirror_list-2.0.0.json (mirror_list v2.0.0, LSTN-01, JSON metadata) - mirror_list_simtel_dat.config.yml: mirror_list_CTA-N-LST1_v2019-03-31_rotated_simtel.dat (mirror_list v2.0.0, LSTN-01, physical file) - array_element_position_ground.config.yml: array_element_position_ground-2.0.0.json (array_element_position_ground v2.0.0, MSTN-09) - array_element_position_utm.config.yml: array_element_position_utm-2.0.0.json (array_element_position_utm v2.0.0, MSTN-09) Part of issue #1600. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Move mirror .dat resource to tests/resources/model_parameters/ using canonical DB filename (mirror_CTA-N-LST1_v2019-03-31_rotated.dat) - Merge mirror_list_simtel_dat.config.yml into mirror_list.config.yml (both files now share the same collection output_path) - Update test_mirrors.py fixture to use the new path Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GernotMaier
added
no-changelog-needed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns unit tests and test-resource generation workflows with the new tests/resources/model_parameters layout for model parameter files.
Changes:
- Updates unit tests to read SPE and mirror-list resources from
tests/resources/model_parameters. - Adds model-parameter resource files used by those tests.
- Adds workflow configuration files for regenerating selected model-parameter test resources.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/unit_tests/visualization/test_plot_tables.py |
Points table-reading tests to the model-parameter resource directory. |
tests/unit_tests/simtel/test_simtel_table_reader.py |
Updates SPE fixture path. |
tests/unit_tests/reporting/test_docs_read_parameters.py |
Updates valid SPE file path. |
tests/unit_tests/model/test_mirrors.py |
Uses the relocated/generated mirror-list resource. |
tests/resources/model_parameters/spe_LST_2022-04-27_AP2.0e-4.dat |
Adds SPE model-parameter data resource. |
tests/resources/model_parameters/mirror_CTA-N-LST1_v2019-03-31_rotated.dat |
Adds mirror-list model-parameter data resource. |
tests/resources_generation/model_parameters/pm_photoelectron_spectrum.config.yml |
Adds workflow config to regenerate SPE resource. |
tests/resources_generation/model_parameters/mirror_list.config.yml |
Adds workflow config to regenerate mirror-list resources. |
tests/resources_generation/model_parameters/array_element_position_utm.config.yml |
Adds workflow config to regenerate UTM position resource. |
tests/resources_generation/model_parameters/array_element_position_ground.config.yml |
Adds workflow config to regenerate ground-position resource. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new configuration files for generating model parameter resources and updates a test to use the correct file path for a mirror list resource. These changes help ensure that tests and resource generation are aligned with the latest file locations and formats.