Skip to content

gh-action workflows zusammenlegen#211

Merged
gamue merged 1 commit intomainfrom
merge-flow
Oct 29, 2025
Merged

gh-action workflows zusammenlegen#211
gamue merged 1 commit intomainfrom
merge-flow

Conversation

@gamue
Copy link
Owner

@gamue gamue commented Oct 29, 2025

No description provided.

@gamue gamue requested a review from Copilot October 29, 2025 22:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates two separate GitHub Actions workflows into a single unified workflow. The changes merge the PR build workflow and deployment workflow into one file that handles both build validation for pull requests and deployment to GitHub Pages for main branch pushes.

  • Merged separate PR and deployment workflows into a unified CI/CD pipeline
  • Added build output validation step to verify site generation
  • Updated workflow to conditionally deploy only on main branch pushes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci-cd.yml Unified workflow that now handles both PR builds and main branch deployments with conditional deployment logic
.github/workflows/build-prs-to-main.yml Removed redundant PR-only workflow as functionality is now in consolidated workflow
Comments suppressed due to low confidence (1)

.github/workflows/ci-cd.yml:11

  • The contents: write permission is granted globally but only needed for deployment. Consider moving this permission to a job-level scope on the deployment step or using a separate job for deployment to follow the principle of least privilege. PR builds don't need write permissions.

@gamue gamue merged commit ce36315 into main Oct 29, 2025
7 checks passed
@gamue gamue deleted the merge-flow branch October 29, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants