fix terminal name retrieval and update packages#3
Merged
gantoreno merged 1 commit intogantoreno:mainfrom Dec 29, 2024
Merged
Conversation
despite convention, TERM_PROGRAM is only set on some terminals and the unwrap() leads to crashes when ran terminals that don't set it, such as Alacritty and kitty (gantoreno#2). This issue is fixed by checking for terminal-specific vars for these two terminals and adds a graceful "unknown" fallback option in case anyone dare use a different terminal emulator. Also had to run cargo update to make the program compile on the newest rust version.
Owner
|
This is great @paraversal, thank you so much for taking the time to come up with this! Since I was a long-time iTerm2 user (now fully switched to Ghostty), I wasn't aware of how little we could rely on |
Closed
gantoreno
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
despite convention,
TERM_PROGRAMis only set on some terminals and theunwrap()leads to crashes when ran terminals that don't set it, such as Alacritty and kitty (#2). This issue is fixed by checking for terminal-specific vars for these two terminals and adds a graceful "unknown" fallback option in case anyone dare use a different terminal emulator.Also had to run
cargo updateto make the program compile on the newest rust version.