Merged
Conversation
When users click links in Monaco editor content, they now open in the system's default browser instead of navigating within the WebView. The fix intercepts the NavigationStarting event and: - Detects if the URL is external (different host/scheme from app) - Cancels the internal navigation - Opens the URL using Process.Start with UseShellExecute This provides a better user experience and prevents the app from being stuck on external web pages. Fixes #62 Co-authored-by: 小小高 <gaoconggit@users.noreply.github.com>
在 MainWindow.axaml 中为 WebView 添加了 WebViewNewWindowRequested 事件处理器。 在 MainWindow.axaml.cs 中： - 引入了 WebViewCore.Enums 命名空间。 - 删除了 OnNavigationStarting 方法中处理外部链接导航的逻辑。 - 新增了 OnNewWindowRequested 方法，用于处理外部链接导航，支持在系统默认浏览器中打开外部链接。
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 8
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if (Uri.TryCreate(appBaseUrl, UriKind.Absolute, out var tempAppUri)) | ||
| { | ||
| e.Url = tempAppUri; | ||
| e.UrlLoadingStrategy = UrlRequestStrategy.OpenExternally; |
There was a problem hiding this comment.
Bug: External Links Redirected to Base URL
In OnNewWindowRequested, when an external link is detected, e.Url is incorrectly overwritten with the app's base URL before setting UrlLoadingStrategy to OpenExternally. This results in the app's base URL opening externally instead of the intended external link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复webview中打开外部 http链接的bug