Skip to content

Ignore trailing blank lines after single-line title-page commands.#333

Merged
fingolfin merged 1 commit intomasterfrom
codex/titlepage-trailing-blank-lines
Mar 8, 2026
Merged

Ignore trailing blank lines after single-line title-page commands.#333
fingolfin merged 1 commit intomasterfrom
codex/titlepage-trailing-blank-lines

Conversation

@fingolfin
Copy link
Member

Trim generated title-page content to avoid stray newlines.
This prevents newline-bearing filenames and empty authors.

Co-authored-by: Codex codex@openai.com

Trim generated title-page content to avoid stray newlines.
This prevents newline-bearing filenames and empty authors.

Co-authored-by: Codex <codex@openai.com>
@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.05%. Comparing base (d89ad60) to head (1145eb7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gap/AutoDocMainFunction.gi 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   90.98%   91.05%   +0.06%     
==========================================
  Files          13       13              
  Lines        2529     2559      +30     
==========================================
+ Hits         2301     2330      +29     
- Misses        228      229       +1     
Files with missing lines Coverage Δ
gap/Parser.gi 95.47% <100.00%> (+0.07%) ⬆️
gap/AutoDocMainFunction.gi 87.13% <95.23%> (+0.35%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
Copy link
Member Author

@mohamed-barakat with that the worksheet in your private repo builds again (well, with the bib file fix (needed by GAPDoc) and the removal of that @URL command (which we dropped support for over 10 years ago; but we may soon have Markdown style links as a better replacement). Afterwards, there are still some broken Refs: apparently if a chapter or (sub)section title contains characters like :, then those are stripped from auto-generated labels. I don't know yet if that's a recent regression or a change we made long ago (depending on that I can revert it, or not...). That said, I am not super happy with our current auto-label system, but that's another matter.

@fingolfin fingolfin merged commit b093281 into master Mar 8, 2026
8 checks passed
@fingolfin fingolfin deleted the codex/titlepage-trailing-blank-lines branch March 8, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant