Skip to content

Handle missing git user config gracefully#68

Merged
fingolfin merged 1 commit intomasterfrom
codex/git-user-config-handling
Mar 17, 2026
Merged

Handle missing git user config gracefully#68
fingolfin merged 1 commit intomasterfrom
codex/git-user-config-handling

Conversation

@fingolfin
Copy link
Copy Markdown
Member

Check for missing git user.name and user.email before creating the
initial commit, prompt the user to retry after configuring git,
and allow aborting git setup without discarding the generated
package directory.

Add regression coverage for the success, abort, and retry paths,
and document the behavior in the README and package manual.

Fixes #55

Co-authored-by: Codex codex@openai.com

Check for missing git user.name and user.email before creating the
initial commit, prompt the user to retry after configuring git,
and allow aborting git setup without discarding the generated
package directory.

Add regression coverage for the success, abort, and retry paths,
and document the behavior in the README and package manual.

Fixes #55

Co-authored-by: Codex <codex@openai.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.58%. Comparing base (027ece7) to head (f56bd8a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gap/generate.g 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   54.19%   55.58%   +1.39%     
==========================================
  Files           9        9              
  Lines         692      716      +24     
==========================================
+ Hits          375      398      +23     
- Misses        317      318       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit 4c0745b into master Mar 17, 2026
7 checks passed
@fingolfin fingolfin deleted the codex/git-user-config-handling branch March 17, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PackageWizard() breaks if git user credentials are not set globally

1 participant