Remove namespace usage from 'fr'#66
Open
ChrisJefferson wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 55.68% 55.67% -0.01%
==========================================
Files 25 25
Lines 15999 15996 -3
==========================================
- Hits 8909 8906 -3
Misses 7090 7090
🚀 New features to boost your workflow:
|
fingolfin
reviewed
Nov 25, 2025
Member
fingolfin
left a comment
There was a problem hiding this comment.
Thank you, I like it! For some background, see also gap-system/gap#6079
But of course it is @laurentbartholdi who needs to decide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a plan that we might remove namespaces from GAP (code using '@'), because the implementation doesn't really work that well.
This PR is an experiment to see how Fr could be fixed, and how nice the code looks, without using '@'. I don't consider this PR a requirement to merge, and it might not even be the nicest way to do this! However, Fr is one of the biggest users of namespaces and '@'.
Similar to how I have handled similar issues in my own packages, I've added a global record 'Fr', and then put all the 'fr' methods inside that. The only place this doesn't work with with attributes / methods, so those I've prefixed with 'Fr_'.
One issue is we can't use 'BindGlobal' any more, so I just assign members of the record.